Improve hidden code detection #213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't _fix_ https://github.com/azerupi/mdBook/issues/155, but it does paper over it 😉
Contributor
Author
|
https://github.com/azerupi/mdBook/pull/214 is much better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix https://github.com/azerupi/mdBook/issues/155, but it
does paper over it 😉
What do you think about this, @azerupi ?
My understanding is that the new docs based on mdbook will be deployed tonight, and I'm expecting we'll get bugs filed about this, so it'd be nice to fix, even if it is just a hack for now. Open to other perspectives as well.